[ https://issues.apache.org/jira/browse/HBASE-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13440097#comment-13440097 ]
Hudson commented on HBASE-5549: ------------------------------- Integrated in HBase-0.94 #417 (See [https://builds.apache.org/job/HBase-0.94/417/]) HBASE-5549 Master can fail if ZooKeeper session expires (Revision 1376374) Result = SUCCESS stack : Files : * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/HMaster.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/TestZooKeeper.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/TestMasterZKSessionRecovery.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/replication/TestReplication.java > Master can fail if ZooKeeper session expires > -------------------------------------------- > > Key: HBASE-5549 > URL: https://issues.apache.org/jira/browse/HBASE-5549 > Project: HBase > Issue Type: Bug > Components: master, zookeeper > Affects Versions: 0.96.0 > Environment: all > Reporter: nkeywal > Assignee: nkeywal > Priority: Minor > Fix For: 0.92.2, 0.96.0, 0.94.2 > > Attachments: 5549_092.txt, 5549_094.txt, 5549.v10.patch, > 5549.v11.patch, 5549.v6.patch, 5549.v7.patch, 5549.v8.patch, 5549.v9.patch, > nochange.patch > > > There is a retry mechanism in RecoverableZooKeeper, but when the session > expires, the whole ZooKeeperWatcher is recreated, hence the retry mechanism > does not work in this case. This is why a sleep is needed in > TestZooKeeper#testMasterSessionExpired: we need to wait for ZooKeeperWatcher > to be recreated before using the connection. > This can happen in real life, it can happen when: > - master & zookeeper starts > - zookeeper connection is cut > - master enters the retry loop > - in the meantime the session expires > - the network comes back, the session is recreated > - the retries continues, but on the wrong object, hence fails. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira