[
https://issues.apache.org/jira/browse/HBASE-29609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18021389#comment-18021389
]
Duo Zhang commented on HBASE-29609:
-----------------------------------
Seems checkstyle is still failing?
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7326/1/artifact/yetus-general-check/output/buildtool-patch-checkstyle-hbase-server.txt
{noformat}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-checkstyle-plugin:3.6.0:checkstyle (default-cli)
on project hbase-server: An error has occurred in Checkstyle report generation.
Failed to create context for skin: Cannot use skin: has [1.11.1,2.0.0-M1) Doxia
Sitetools prerequisite, but current is 2.0.0 -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
{noformat}
I suggest we revert the change here first, and apply the branch-2 change of
HBASE-29448 to branch-3+ to fix site build. We can continue the checkstyle
updating later...
[~paksyd] [~stoty] WDYT?
Thanks.
> Upgrade checkstyle and Maven checkstyle plugin to fix site build failure
> ------------------------------------------------------------------------
>
> Key: HBASE-29609
> URL: https://issues.apache.org/jira/browse/HBASE-29609
> Project: HBase
> Issue Type: Improvement
> Components: build
> Reporter: Dávid Paksy
> Assignee: Dávid Paksy
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.0.0-beta-2
>
>
> Right now our website build fails in the checkstyle check on master:
> {noformat}
> Caused by: java.lang.IllegalStateException:
> /home/jenkins/70ad3735/workspace/hbase_generate_website/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RestoreBackupSystemTableProcedure.java:103:47:
> expecting COLON, found ','{noformat}
> [https://ci-hbase.apache.org/job/hbase_generate_website/806/artifact/hbase-site-log-0f11becf47612de1af5c39fcc26ccb626a0dc310.txt]
>
> The problematic code line:
> {noformat}
> case RESTORE_BACKUP_SYSTEM_TABLE_DISABLE,
> RESTORE_BACKUP_SYSTEM_TABLE_PREPARE:{noformat}
> It seems our current checkstyle version does not like multiple values on the
> same case statement.
> RestoreBackupSystemTableProcedure was just introduced under
> https://issues.apache.org/jira/browse/HBASE-29448.
> Upgrading checkstyle and the Maven plugin seems to fix the issue.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
