[ https://issues.apache.org/jira/browse/HBASE-5329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13440110#comment-13440110 ]
Hadoop QA commented on HBASE-5329: ---------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12542080/5329-v2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings). -1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient org.apache.hadoop.hbase.master.TestSplitLogManager Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2658//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2658//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2658//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2658//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2658//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2658//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2658//console This message is automatically generated. > addRowLock() may allocate duplicate lock id, causing the client to be blocked > ----------------------------------------------------------------------------- > > Key: HBASE-5329 > URL: https://issues.apache.org/jira/browse/HBASE-5329 > Project: HBase > Issue Type: Bug > Components: regionserver > Affects Versions: 0.90.3 > Environment: Red Hat Enterprise Linux Server release 5.4 > Reporter: liaoxiangui > Assignee: Ian Varley > Priority: Minor > Fix For: 0.96.0 > > Attachments: 5329-v2.patch, HBASE-5329.patch > > > {code} > protected long addRowLock(Integer r, HRegion region) throws > LeaseStillHeldException > { > long lockId = -1L; > lockId = rand.nextLong(); //!!!may generate duplicated > id,bug? > String lockName = String.valueOf(lockId); > rowlocks.put(lockName, r); > this.leases.createLease(lockName, new RowLockListener(lockName, > region)); > return lockId; > } > {code} > In addRowLock(),rand may generate duplicated lock id, it may cause > regionserver throw exception(Leases$LeaseStillHeldException).The client will > be blocked until old rowlock is released. > {code} > 2012-02-03 15:21:50,084 ERROR > org.apache.hadoop.hbase.regionserver.HRegionServer: Error obtaining row lock > (fsOk: true) > org.apache.hadoop.hbase.regionserver.Leases$LeaseStillHeldException > at > org.apache.hadoop.hbase.regionserver.Leases.createLease(Leases.java:150) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.addRowLock(HRegionServer.java:1986) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.lockRow(HRegionServer.java:1963) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) > at java.lang.reflect.Method.invoke(Method.java:597) > at org.apache.hadoop.hbase.ipc.HBaseRPC$Server.call(HBaseRPC.java:570) > at > org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1039) > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira