stoty commented on code in PR #7327:
URL: https://github.com/apache/hbase/pull/7327#discussion_r2362525566
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsKillRS.java:
##########
@@ -268,24 +266,26 @@ public void testLowerMetaGroupVersion() throws Exception {
Address address = servers.iterator().next();
int majorVersion = VersionInfo.getMajorVersion(originVersion);
assertTrue(majorVersion >= 1);
- String lowerVersion = String.valueOf(majorVersion - 1) +
originVersion.split("\\.")[1];
- setFinalStatic(Version.class.getField("version"), lowerVersion);
- TEST_UTIL.getMiniHBaseCluster().startRegionServer(address.getHostName(),
address.getPort());
- assertEquals(NUM_SLAVES_BASE,
- TEST_UTIL.getMiniHBaseCluster().getLiveRegionServerThreads().size());
- assertTrue(VersionInfo.compareVersion(originVersion,
- MASTER.getRegionServerVersion(getServerName(servers.iterator().next())))
> 0);
- LOG.debug("wait for META assigned...");
- // SCP finished, which means all regions assigned too.
- TEST_UTIL.waitFor(60000, () ->
!TEST_UTIL.getHBaseCluster().getMaster().getProcedures().stream()
- .filter(p -> (p instanceof ServerCrashProcedure)).findAny().isPresent());
+ String lowerVersion = String.valueOf(majorVersion - 1) +
originVersion.substring(originVersion.indexOf("."));
+ try {
+ setVersionInfoVersion(lowerVersion);
+ TEST_UTIL.getMiniHBaseCluster().startRegionServer(address.getHostName(),
address.getPort());
+ assertEquals(NUM_SLAVES_BASE,
+ TEST_UTIL.getMiniHBaseCluster().getLiveRegionServerThreads().size());
+ assertTrue(VersionInfo.compareVersion(originVersion,
+
MASTER.getRegionServerVersion(getServerName(servers.iterator().next()))) > 0);
Review Comment:
This is unrelated, but the version expression was incorrect here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
