sidkhillon commented on code in PR #7346:
URL: https://github.com/apache/hbase/pull/7346#discussion_r2380670336
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/IncrementalTableBackupClient.java:
##########
@@ -242,7 +245,7 @@ private void mergeSplitAndCopyBulkloadedHFiles(List<String>
files, TableName tn,
incrementalCopyBulkloadHFiles(tgtFs, tn);
}
- private void updateFileLists(List<String> activeFiles, List<String>
archiveFiles)
+ public void updateFileLists(List<String> activeFiles, List<String>
archiveFiles)
Review Comment:
The TestIncrementalBackupWithBulkload test class isn't in the same package
(...hbase.backup.impl vs hbase.backup), so the test method can't access the
protected method. We could either:
- separate just these 2 test methods into their own "impl" test file in a
impl package
- leave it as being public
- move all the TestincrementalBackup* files to a impl module (moving just
one seems confusing to future readers)
I would lean towards the first option -- what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
