[ 
https://issues.apache.org/jira/browse/HBASE-6564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13440486#comment-13440486
 ] 

Zhihong Ted Yu commented on HBASE-6564:
---------------------------------------

TestHRegion failed. See 
https://builds.apache.org/job/PreCommit-HBASE-Build/2669/console
{code}
+  public void deleteFamily(HRegionInfo region, byte[] familyName)
{code}
Please rename the above method deleteFamilyFromFS().
{code}
+      if (fs.delete(delDir, true) == false) {
+      throw new IOException("Could not delete family "
{code}
Indent the throw statement to the right by two spaces.
{code}
+          + Bytes.toString(familyName) + " from FileSystem for region "
+          + region.getTableNameAsString());
{code}
I think getTableNameAsString() shouldn't be used because you want to tell user 
the name of the region.
For TestTableDeleteFamilyHandler.java:
{code}
+ * Copyright 2012 The Apache Software Foundation
{code}
Year is not needed in license header.

                
> HDFS space is not reclaimed when a column family is deleted
> -----------------------------------------------------------
>
>                 Key: HBASE-6564
>                 URL: https://issues.apache.org/jira/browse/HBASE-6564
>             Project: HBase
>          Issue Type: Bug
>          Components: master
>    Affects Versions: 0.94.1
>            Reporter: J Mohamed Zahoor
>            Assignee: J Mohamed Zahoor
>            Priority: Minor
>         Attachments: HBASE-6564-trunk.patch, HBASE-6564-v2.patch, 
> HBASE-6564-v3.patch, HBASE-6564-v4.patch
>
>
> When a column family of a table is deleted, the HDFS space of the column 
> family does not seem to be reclaimed even after a major compaction.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to