PDavid commented on PR #7353: URL: https://github.com/apache/hbase/pull/7353#issuecomment-3355024231
> I would split the skin replacement and the checkstyle update into separate tickets and PRs if possible. (i.e. if the new skins works with the old checkstyle) Thanks for the suggestion. Sure, actually, I was wondering about the same thing: to do these separately. However having them in the same PR proves that the new skin works with the new checkstyle version. But of course I can separate them. :) > > I also suggest starting a [DISCUSS] thread about the skin update to make sure that everyone is aware of this and has a chance to comment. Good idea, I'll do that. > Also, there is some information on why HBase needed the hacked theme in the old tickets. Were you able to verify the problem areas and confirm that the new skin is free from the bugs that had to be patched ? I checked the [commits on the 1.4 branch of the fork](https://github.com/joshelser/maven-fluido-skin/commits/1.4-HBase-patched/) which were made in 2019, since a lot of time passed, even the original Maven fluido skin is now at 2.1.0 version and I did not found any issues with the new skin I thought the original problems might not be present anymore. But I'll look into this to be sure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
