krconv commented on code in PR #7360:
URL: https://github.com/apache/hbase/pull/7360#discussion_r2410934260
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/BackupHFileCleaner.java:
##########
@@ -52,10 +52,13 @@ public class BackupHFileCleaner extends
BaseHFileCleanerDelegate implements Abor
private boolean stopped = false;
private boolean aborted = false;
private Connection connection;
- // timestamp of most recent read from backup system table
- private long prevReadFromBackupTbl = 0;
- // timestamp of 2nd most recent read from backup system table
- private long secondPrevReadFromBackupTbl = 0;
+ // timestamp of most recent completed cleaning run
+ private volatile long previousCleaningCompletionTimestamp = 0;
+
+ @Override
+ public void postClean() {
Review Comment:
I agree that this definitely looks like an oversight from the original
implementation, and that this change corrects it to work as it seems it was
originally intended
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
