[
https://issues.apache.org/jira/browse/HBASE-6633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13440645#comment-13440645
]
Hadoop QA commented on HBASE-6633:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12542171/HBASE-6633.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 9 new or modified tests.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 5 javac compiler warnings (more than
the trunk's current 4 warnings).
-1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.io.encoding.TestUpgradeFromHFileV1ToEncoding
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/2671//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2671//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2671//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2671//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2671//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2671//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/2671//console
This message is automatically generated.
> Adding new hooks to the split flow - For roll backs and one final hook after
> split is completed either successfully or failed
> -----------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-6633
> URL: https://issues.apache.org/jira/browse/HBASE-6633
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Labels: coprocessors
> Attachments: HBASE-6633.patch
>
>
> Currently we have two hooks in the split flow of a region. PreSplit() and
> postSplit(). But not always these are helpful in case i have a problem in
> preSplit() or postSplit() i need to do a rollback of the current region or
> the region that i am handling thro the hooks.
> So its better if we have a hook in the rollback code and also one final hook
> say postCompleteSplit() so that CP can take any corrective action.
> Pls do suggest if i can provide a patch for this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
