wchevreuil commented on code in PR #7364:
URL: https://github.com/apache/hbase/pull/7364#discussion_r2410009034


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java:
##########
@@ -162,7 +162,6 @@ public class CacheConfig implements 
PropagatingConfigurationObserver {
 
   private final ByteBuffAllocator byteBuffAllocator;
 
-

Review Comment:
   nit: remove unnecessary change.



##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupAdminImpl.java:
##########
@@ -185,6 +185,7 @@ private void finalizeDelete(List<String> backupRoots, 
BackupSystemTable table)
       incrTableSet.retainAll(tableMap.keySet());
 
       table.deleteIncrementalBackupTableSet(backupRoot);
+      busySpin(5);

Review Comment:
   Could we do with a simple wait() instead?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to