Apache9 commented on code in PR #7366:
URL: https://github.com/apache/hbase/pull/7366#discussion_r2410541434
##########
hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseJupiterExtension.java:
##########
@@ -60,14 +62,17 @@
* the tag.
* <p>
* It also controls the timeout for the whole test class running, while the
timeout annotation in
- * JUnit5 can only enforce the timeout for each test method.
+ * JUnit5 can only enforce the timeout for each test method. When a test is
timed out, a thread dump
+ * will be printed to log output.
* <p>
- * Finally, it also forbid System.exit call in tests. TODO: need to find a new
way as
- * SecurityManager has been removed since Java 21.
+ * It also implements resource check for each test method, using the {@link
ResourceChecker} class.
+ * <p>
+ * Finally, it also forbid System.exit call in tests. <br>
+ * TODO: need to find a new way as SecurityManager has been disabled since
Java 24.
Review Comment:
Hallucination...
https://openjdk.org/jeps/486, the JEP for permanently disabling
SecurityManager is released in java 24.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
