PDavid commented on code in PR #7355:
URL: https://github.com/apache/hbase/pull/7355#discussion_r2393803823
##########
src/site/site.xml:
##########
@@ -123,35 +98,35 @@
<item name="Bulk Loads" href="book.html#arch.bulk.load" target="_blank"
/>
<item name="Metrics" href="metrics.html" target="_blank" />
<item name="Cluster replication" href="book.html#replication"
target="_blank" />
- <item name="1.4 Documentation">
+ <item name="1.4 Documentation" href="documentation-1.4.html">
Review Comment:
These sub-menus rendered a bit strangely in the footer:
<img width="2682" height="1404" alt="image"
src="https://github.com/user-attachments/assets/f62bf751-b0db-46fc-bced-c85ef875f6d9";
/>
In order for fix this I added custom pages for each of these documentations.
<img width="2631" height="1502" alt="image"
src="https://github.com/user-attachments/assets/f72b28f2-62cf-4182-a73b-622bee04d11f";
/>
Alternatively we could disable to have the menus in the footer but I believe
having the menus in the footer is quite useful especially on mobile view
(because the navbar is a bit hard to use on mobile with submenus).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
