taklwu commented on code in PR #7400:
URL: https://github.com/apache/hbase/pull/7400#discussion_r2449797758
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/IncrementalTableBackupClient.java:
##########
@@ -533,11 +543,7 @@ protected void walToHFiles(List<String> dirPaths,
List<String> tableList, long p
conf.set(JOB_NAME_CONF_KEY, jobname);
if (backupInfo.isContinuousBackupEnabled()) {
conf.set(WALInputFormat.START_TIME_KEY, Long.toString(previousBackupTs));
- // committedWALsTs is needed only for Incremental backups with
continuous backup
- // since these do not depend on log roll ts
- long committedWALsTs = BackupUtils.getReplicationCheckpoint(conn);
- backupInfo.setIncrCommittedWalTs(committedWALsTs);
- conf.set(WALInputFormat.END_TIME_KEY, Long.toString(committedWALsTs));
+ conf.set(WALInputFormat.END_TIME_KEY,
Long.toString(backupInfo.getIncrCommittedWalTs()));
Review Comment:
or do you mean `beginBackup` will only include the `committedWALsTs` such we
will not need to recalculate the `END_TIME_KEY` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
