Apache9 commented on code in PR #7363:
URL: https://github.com/apache/hbase/pull/7363#discussion_r2450193213
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncBufferedMutatorImpl.java:
##########
@@ -90,19 +108,41 @@ public Configuration getConfiguration() {
// will be overridden in test
protected void internalFlush() {
- if (periodicFlushTask != null) {
- periodicFlushTask.cancel();
- periodicFlushTask = null;
- }
- List<Mutation> toSend = this.mutations;
- if (toSend.isEmpty()) {
- return;
+ internalFlush(FlushType.MANUAL);
+ }
+
+ protected void internalFlush(FlushType trigger) {
Review Comment:
For the test, I think you can just comment it out first, IIRC it was
introduced to verify a race issue. If we comletely change the implementation,
maybe we can just drop the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
