sharmaar12 commented on code in PR #7385:
URL: https://github.com/apache/hbase/pull/7385#discussion_r2474121638


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java:
##########
@@ -344,6 +345,11 @@ protected void requestCompactionInternal(HRegion region, 
HStore store, String wh
       return;
     }
 
+    if (isReadOnlyEnabled()) {
+      LOG.info("Ignoring compaction request for " + region + ",because 
read-only mode is on.");
+      return;
+    }
+

Review Comment:
   Then we may need to at least modify the log messages to mention that either 
compaction is disabled or readonly mode is on. Otherwise compaction may be 
enabled but we are logging it as disabled because of read-only mode.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to