junegunn commented on code in PR #7432:
URL: https://github.com/apache/hbase/pull/7432#discussion_r2486631304
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java:
##########
@@ -1099,6 +1099,9 @@ public static ClientProtos.Scan toScan(final Scan scan)
throws IOException {
scanBuilder.setNeedCursorResult(true);
}
scanBuilder.setQueryMetricsEnabled(scan.isQueryMetricsEnabled());
+ if (scan.getLimit() > 0) {
Review Comment:
The absence of it only matters when Protobuf serialization is involved. For
example, in the existing test cases in `TestTableInputFormat`, 1. no
serialization was performed, and 2. no `Scan#setLimit` call was made, so the
issue never surfaced. So I guess this particular case (Protobuf serialization
of a Scan object with a non-default limit) wasn't previously covered by the
unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
