Umeshkumar9414 commented on code in PR #7375:
URL: https://github.com/apache/hbase/pull/7375#discussion_r2513275803
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java:
##########
@@ -1873,6 +1881,20 @@ public void visitRegionState(Result result, final
RegionInfo regionInfo, final S
if (regionNode.getProcedure() != null) {
regionNode.getProcedure().stateLoaded(AssignmentManager.this,
regionNode);
}
+ // add regions to RIT while visiting the meta
+ regionInTransitionTracker.handleRegionStateNodeOperation(regionNode);
+ // If region location of region belongs to a dead server mark the region
crashed
+ if (
+ regionNode.getRegionLocation() != null
+ &&
master.getServerManager().isServerDead(regionNode.getRegionLocation())
+ ) {
+ Date timeOfCrash =
Review Comment:
changed method getTimeOfDeath to return long and also did one change in.
Alternate of that is
` long deathTime = deadServerUtil.getTimeOfDeath(deadServerName);
%>
<tr>
<th></th>
<td><%= deadServerName %></td>
<td><%= deathTime !=0 ? new Date(deathTime) : null %></td>`
Let me know if current changes are good or this one would be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
