Apache9 commented on code in PR #7454:
URL: https://github.com/apache/hbase/pull/7454#discussion_r2514599713
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncScanSingleRegionRpcRetryingCaller.java:
##########
@@ -460,9 +460,9 @@ private void onError(Throwable error) {
retryTimer.newTimeout(t -> call(), delayNs, TimeUnit.NANOSECONDS);
}
- private void updateNextStartRowWhenError(Result result) {
+ private void updateNextStartRowWhenError(Result result, boolean
isHeartbeatMessage) {
Review Comment:
Mind adding some comments to describe the behavior? Especially on 3.x we do
not have sync client implementation any more, we'd better add some comments so
later developers could still know why we need this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
