Umeshkumar9414 commented on code in PR #7375:
URL: https://github.com/apache/hbase/pull/7375#discussion_r2515324742


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java:
##########
@@ -3081,7 +3082,7 @@ public ClusterMetrics 
getClusterMetricsWithoutCoprocessor(EnumSet<Option> option
         case REGIONS_IN_TRANSITION: {
           if (assignmentManager != null) {
             builder.setRegionsInTransition(
-              
assignmentManager.getRegionStates().getRegionsStateInTransition());
+              new 
ArrayList<>(assignmentManager.getRegionsStateInTransition()));

Review Comment:
   We used to have two methods earlier getRegionsStateInTransition for 
unordered list and getRegionsInTransitionOrderedByTimestamp for SortedSet. 
Andrew suggested to return sorted set always becuase while returning the 
unordered list also we had to run a loop to get regionState from 
RegionStateNode.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to