PDavid commented on code in PR #7390:
URL: https://github.com/apache/hbase/pull/7390#discussion_r2518091017
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/tool/TestCanaryTool.java:
##########
@@ -437,4 +449,137 @@ private void testZookeeperCanaryWithArgs(String[] args)
throws Exception {
HConstants.DEFAULT_ZOOKEEPER_ZNODE_PARENT);
verify(sink, atLeastOnce()).publishReadTiming(eq(baseZnode), eq(hostPort),
anyLong());
}
+
Review Comment:
I deleted `TestCanaryStatusServlet` because it only rendered the Canary
Status Jamon page with mock objects and asserted the results. The servlet only
has the redirect logic, and that is tested by these new tests.
These new tests are testing the Canary Status web UI page (which is rendered
by JSP) with some mock objects and I did not created a separate test class for
these as these require a mini cluster and this way we can use what this test
spins up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
