taklwu commented on code in PR #7463:
URL: https://github.com/apache/hbase/pull/7463#discussion_r2540142826
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDeadServer.java:
##########
@@ -104,15 +93,15 @@ public void testIsDead() {
}
@Test
- public void testCrashProcedureReplay() {
+ public void testCrashProcedureReplay() throws IOException {
HMaster master = TEST_UTIL.getHBaseCluster().getMaster();
final ProcedureExecutor<MasterProcedureEnv> pExecutor =
master.getMasterProcedureExecutor();
ServerCrashProcedure proc =
new ServerCrashProcedure(pExecutor.getEnvironment(), hostname123, false,
false);
ProcedureTestingUtility.submitAndWait(pExecutor, proc);
-
assertFalse(master.getServerManager().getDeadServers().areDeadServersInProgress());
+ assertTrue(master.getServerManager().areDeadServersInProgress());
Review Comment:
we will also need https://issues.apache.org/jira/browse/HBASE-25334 /
https://github.com/apache/hbase/commit/a9b8c10f8029bcc02a6d3a44ce4f9ab51187e4eb
after this cherry-pick to have the right behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
