stoty commented on code in PR #7470:
URL: https://github.com/apache/hbase/pull/7470#discussion_r2549009327


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java:
##########
@@ -3469,12 +3469,18 @@ private void scan(HBaseRpcController controller, 
ScanRequest request, RegionScan
           limitReached = sizeLimitReached || timeLimitReached || 
resultsLimitReached;

Review Comment:
   Not in the scope of this backport ticket, but why do we check only those two 
limits ?
   is batch size not applicable here ? Why do we ignore the heap size limit ?
   
   Maybe worth looking into this in another JIRA.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to