taklwu commented on PR #7476: URL: https://github.com/apache/hbase/pull/7476#issuecomment-3572125891
> [HBASE-25334](https://issues.apache.org/jira/browse/HBASE-25334) is already in present in 2.5 and 2.6. > > You should probably change the ticket name and description to reflect the real situation. > > Did something broke the original patch in the meantime ? Was the original commit incorrect/incomplete ? Or is this needed for some other reason ? in my review in https://github.com/apache/hbase/pull/7472#pullrequestreview-3490065287, I mentioned about that HBASE-25334 (https://github.com/apache/hbase/commit/32c4432b9b7c68ae20fa753f0ceb448026d4cd39) was a partial patch that does not have the changes in [ServerManager.java](https://github.com/apache/hbase/pull/7472/files#diff-4425673bc02ca264ceb292943cf3816fc4f5e51e3680656586ec6bbf5be29959) and thus we had first backport https://issues.apache.org/jira/browse/HBASE-29720 , and then add those missing changes in the PR of https://github.com/apache/hbase/pull/7472 against branch-2 (merged), and now this one. branch-2 has been merged and the title cannot be changed (IMO developer would also look into the changes of commit), it's fine to change the title of this PR to match what is requesting, I will also add some information in the commit body about it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
