kgeisz commented on code in PR #7526:
URL: https://github.com/apache/hbase/pull/7526#discussion_r2595578446
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java:
##########
@@ -2334,11 +2334,15 @@ public CompletableFuture<Void>
regionClosedAbnormally(RegionStateNode regionNode
public void markRegionsAsCrashed(List<RegionInfo> regionsOnCrashedServer,
ServerCrashProcedure scp) {
ServerName crashedServerName = scp.getServerName();
+ assert crashedServerName != null;
for (RegionInfo regionInfo : regionsOnCrashedServer) {
RegionStateNode node =
regionStates.getOrCreateRegionStateNode(regionInfo);
- if (node.getRegionLocation() == crashedServerName) {
+ if (crashedServerName.equals(node.getRegionLocation())) {
node.crashed(scp.getSubmittedTime());
regionInTransitionTracker.regionCrashed(node);
+ } else {
+ LOG.warn("Region {} should be on crashed region server{} but is
recorded on {}", regionInfo,
Review Comment:
nit
```suggestion
LOG.warn("Region {} should be on crashed region server {} but is
recorded on {}", regionInfo,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
