ankitsol commented on code in PR #7528:
URL: https://github.com/apache/hbase/pull/7528#discussion_r2621669222
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/ReplicationEndpoint.java:
##########
@@ -216,7 +216,7 @@ public int getTimeout() {
* the context are assumed to be persisted in the target cluster.
Review Comment:
@Apache9 This seems like a good approach. We also want it to be both time
and size based.
I have two questions regarding time based approach
1) Should this time based count run on a separate thread. Currently in
`ContinuousBackupReplicationEndpoint` we implemented it as a separate thread
2) Where should be save time/size based context? `ReplicationSourceShipper`
or `ReplicationSource`, considering 'ReplicationSourceShipper' is itself a
thread
CC @anmolnar @vinayakphegde
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
