wchevreuil commented on code in PR #7555:
URL: https://github.com/apache/hbase/pull/7555#discussion_r2626580228
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/ReadOnlyController.java:
##########
@@ -105,6 +105,11 @@ private void internalReadOnlyGuard() throws IOException {
}
}
+ private boolean
+ isOperationOnNonMetaTable(final ObserverContext<? extends
RegionCoprocessorEnvironment> c) {
Review Comment:
nit: Simply call it "isOnMeta" and return the check
c.getEnvironment().getRegionInfo().getTable().equals(TableName.META_TABLE_NAME),
moving the negation check to the callers? eg:
...
if (!isOnMeta(c)) {
internalReadOnlyGuard();
}
...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
