Apache9 commented on PR #7577:
URL: https://github.com/apache/hbase/pull/7577#issuecomment-3694759356
> > Since we have a Configuration Object in ReplicationPeerConfig, what
about just create a combined Configuration instance and use it when creating
ReplicationSource? In this way you can directly change the sleepForRetry
through the configuration.
>
> Just to confirm, you're suggesting I use the existing `configuration` map
in ReplicationPeerConfig and store the value as
"replication.source.sleepforretries". Then, we can override the config by doing
something like:
>
> ```java
> Configuration combinedConf = new Configuration(globalConf);
> // Override any values in globalConf with the existing value in peerConfig
> peerConfig.getConfiguration().forEach(combinedConf::set);
> // set this.conf = combinedConf in the ReplicationSource
> ```
>
> Set peer-specific override via `update_peer_config '1', CONFIG =>
{"replication.source.sleepforretries" => 2000}`
>
> Is that the approach you are looking for?
Yes.
More specific, we can change the code in
ReplicationSourceManager.createSource.
We have a CompoundConfiguration in hbase, where we can merge multiple
Configurations together. You can check
ReplicationPeerConfigUtil.getPeerClusterConfiguration method to find the usage.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
