junegunn commented on PR #7580: URL: https://github.com/apache/hbase/pull/7580#issuecomment-3709402732
> I mean we should just remove the getInstance method I explained why I didn't take the approach above. > However, it is possible that existing custom `AuthenticationProviderSelectors` might rely on this single-instantiation behavior and perform costly operations in their `configure` method. If I'm not mistaken, the motivation behind HBASE-23347 was to allow users to implement their own `AuthenticationProviderSelector`. My concern was that some implementations out there may rely on the documented "exactly once per implementation" property and assume that configure is called only once. https://github.com/apache/hbase/blob/130453d573d6c8ac2e79345061aa4567546ac7e2/hbase-client/src/main/java/org/apache/hadoop/hbase/security/provider/AuthenticationProviderSelector.java#L34-L38 I can't decide if we should be concerned about the possibility. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
