Umeshkumar9414 commented on code in PR #7490:
URL: https://github.com/apache/hbase/pull/7490#discussion_r2687841540


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcExecutor.java:
##########
@@ -296,7 +309,7 @@ protected void startHandlers(final String nameSuffix, final 
int numHandlers,
    */
   private static final QueueBalancer ONE_QUEUE = val -> 0;
 
-  public static QueueBalancer getBalancer(final String executorName, final 
Configuration conf,
+  protected static QueueBalancer getBalancer(final String executorName, final 
Configuration conf,

Review Comment:
   This method creates the balancer for RPC queues, so I don't think it should 
be visible outside of the protected visibility. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to