taklwu commented on code in PR #7625:
URL: https://github.com/apache/hbase/pull/7625#discussion_r2692193929
##########
hbase-it/src/test/java/org/apache/hadoop/hbase/backup/IntegrationTestBackupRestoreBase.java:
##########
@@ -715,6 +715,47 @@ protected Set<String> getColumnFamilies() {
return null;
}
+ /**
+ * This method is useful for ensuring important test parameters are
initialized when running
+ * integration tests in IntelliJ or in the command line with Maven. Tests
executed in the command
+ * line via the bin/hbase command have their parameters set in
+ * {@link IntegrationTestBase#processOptions}
+ */
+ protected void initializeTestParameters() {
+ util = new IntegrationTestingUtility();
+ conf = util.getConfiguration();
+
+ if (regionsCountPerServer == -1) {
+ regionsCountPerServer = conf.getInt(REGION_COUNT_KEY,
DEFAULT_REGION_COUNT);
+ }
+ LOG.info("regionsCountPerServer is set to {}", regionsCountPerServer);
+
+ if (regionServerCount == -1) {
+ regionServerCount = conf.getInt(REGIONSERVER_COUNT_KEY,
DEFAULT_REGIONSERVER_COUNT);
+ }
+ LOG.info("regionServerCount is set to {}", regionServerCount);
+
+ if (rowsInIteration == -1) {
+ rowsInIteration = conf.getInt(ROWS_PER_ITERATION_KEY,
DEFAULT_ROWS_IN_ITERATION);
+ }
+ LOG.info("rowsInIteration is set to {}", rowsInIteration);
+
+ if (numIterations == -1) {
+ numIterations = conf.getInt(NUM_ITERATIONS_KEY, DEFAULT_NUM_ITERATIONS);
+ }
+ LOG.info("numIterations is set to {}", numIterations);
Review Comment:
LOG.info should be better to debug or even remove them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
