ndimiduk commented on PR #7670:
URL: https://github.com/apache/hbase/pull/7670#issuecomment-3789939015

   > I'm not 100% sure on the `conf`. In certain cases it might be useful to 
run a full test when the default config changes as it could introduce problems.
   
   I considered this. My conclusion is that `hbase-default.xml` is a resource 
read from 
https://github.com/apache/hbase/blob/master/hbase-common/src/main/resources/hbase-default.xml
 . Unit tests don't use conf at all. Maybe there's some integration test that 
references conf, but it own't be a junit/maven test. I don't think.
   
   > IIRC, if we change the files under dev-support, we will still trigger a 
yetus run, but just some very basic checks?
   
   That's my understanding, yes, the General Checks still apply because they're 
evaluating changed files. Module selection is part of the unit testing check, 
in our case, junit + maven.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to