[
https://issues.apache.org/jira/browse/HBASE-6689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444514#comment-13444514
]
Hadoop QA commented on HBASE-6689:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12542998/HBASE-6689.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
-1 javadoc. The javadoc tool appears to have generated 110 warning
messages.
-1 javac. The applied patch generated 5 javac compiler warnings (more than
the trunk's current 4 warnings).
-1 findbugs. The patch appears to introduce 9 new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.replication.TestReplication
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/2728//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2728//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2728//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2728//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2728//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2728//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/2728//console
This message is automatically generated.
> HRegion.increment comment nits
> ------------------------------
>
> Key: HBASE-6689
> URL: https://issues.apache.org/jira/browse/HBASE-6689
> Project: HBase
> Issue Type: Improvement
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Priority: Trivial
> Fix For: 0.96.0
>
> Attachments: HBASE-6689.patch
>
>
> Just a couple of trivial nits with the comments in this area of code:
> - In the test, a thread is called reader when it never actually reads, just
> flushes
> - The WAL edits are prepared per column family, then the WAL is written once
> all the column families have been checked. But the comment says "// Append
> update to WAL" (as if it were being written) when the edits are just being
> prepared on a single column family.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
