[
https://issues.apache.org/jira/browse/HBASE-29859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiao Liu updated HBASE-29859:
-----------------------------
Description:
In the {{DataTieringManager.instantiate}} method, if {{DataTieringFeature}} is
not enabled, we still see the log message {{{}DataTieringManager is already
instantiated.{}}}, which is quite confusing. The code is as follows:
{code:java}
public static synchronized boolean instantiate(Configuration conf,
Map<String, HRegion> onlineRegions) {
if (isDataTieringFeatureEnabled(conf) && instance == null) {
instance = new DataTieringManager(onlineRegions);
LOG.info("DataTieringManager instantiated successfully.");
return true;
} else {
LOG.warn("DataTieringManager is already instantiated.");
}
return false;
} {code}
was:
In the \{{DataTieringManager.instantiate}} method, if \{{DataTieringFeature}}
is not enabled, we still see the log message \{{DataTieringManager is already
instantiated.}}, which is quite confusing. The code is as follows:
{code:language=java|borderStyle=solid|theme=RDark|linenumbers=true|collapse=false}
public static synchronized boolean instantiate(Configuration conf,
Map<String, HRegion> onlineRegions) {
if (isDataTieringFeatureEnabled(conf) && instance == null) {
instance = new DataTieringManager(onlineRegions);
LOG.info("DataTieringManager instantiated successfully.");
return true;
} else {
LOG.warn("DataTieringManager is already instantiated.");
}
return false;
}
{code}
> Initialization log for DataTieringManager is incorrect
> ------------------------------------------------------
>
> Key: HBASE-29859
> URL: https://issues.apache.org/jira/browse/HBASE-29859
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 3.0.0-beta-1
> Reporter: Xiao Liu
> Assignee: Xiao Liu
> Priority: Minor
> Fix For: 3.0.0-beta-2
>
>
> In the {{DataTieringManager.instantiate}} method, if {{DataTieringFeature}}
> is not enabled, we still see the log message {{{}DataTieringManager is
> already instantiated.{}}}, which is quite confusing. The code is as follows:
> {code:java}
> public static synchronized boolean instantiate(Configuration conf,
> Map<String, HRegion> onlineRegions) {
> if (isDataTieringFeatureEnabled(conf) && instance == null) {
> instance = new DataTieringManager(onlineRegions);
> LOG.info("DataTieringManager instantiated successfully.");
> return true;
> } else {
> LOG.warn("DataTieringManager is already instantiated.");
> }
> return false;
> } {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
