ndimiduk commented on code in PR #7651:
URL: https://github.com/apache/hbase/pull/7651#discussion_r2764931526
##########
pom.xml:
##########
@@ -4610,6 +4611,91 @@
<surefire.secondPartGroups/>
</properties>
</profile>
+ <profile>
+ <!--
+ Wave profiles for partitioning Large tests across parallel CI jobs.
+ Tests are split alphabetically by class name (after "Test" prefix):
+ Wave 1: Test[A-H]* classes
+ Wave 2: Test[I-R]* classes
+ Wave 3: Test[S-Z]* classes
+
+ Flaky test exclusion is handled separately via -Dtest.exclude.pattern
+ which is set by hbase-personality.sh from EXCLUDE_TESTS_URL.
+ -->
+ <id>runLargeTests-wave1</id>
+ <activation>
+ <activeByDefault>false</activeByDefault>
+ </activation>
+ <properties>
+ <surefire.skipFirstPart>false</surefire.skipFirstPart>
+ <surefire.skipSecondPart>true</surefire.skipSecondPart>
+
<surefire.firstPartGroups>org.apache.hadoop.hbase.testclassification.LargeTests</surefire.firstPartGroups>
+ <surefire.secondPartGroups/>
+ </properties>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <configuration>
+ <includes>
Review Comment:
Okay so what I found is, when using the Category selector + the wave include
list + the exclude list, all these work together as you would hope: only Large
tests are run, which match the include regex, and entries found in the exclude
list are indeed excluded.
However, if the yetus feature that adds `-Dtest.include.pattern`, i think
it'll override the includes defined here. I'm not sure if that feature is
used... anyway, I think that I prefer these wave definitions live here in the
pom, rather than up in the GHA or personality script or whatever.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
