DieterDP-ng opened a new pull request, #7717: URL: https://github.com/apache/hbase/pull/7717
The BackupLogCleaner prevents WAL files that are needed for future backups from being deleted. In the case where a backup root has a single running backup, there was a small timeframe where relevant files were unprotected because only completed backups were taken into consideration. This commit fixes this. The old mechanism relied on the "backup start code", which is a timestamp that denotes (per backup root) the lowest (earliest) log-roll timestamp that occurred for the backup. Because this concept had no added value, but is complex to reason about, it is removed. Usages are replaced with equal behavior based on timestamps stored in the backup info. (The backup start codes were calculated in the same way, just stored separately.) Note that the backup start code calculation suffers from HBASE-29628 (log-roll timestamps of decommissioned region servers are not cleaned up, causing the start code to be lower than it should be). That problem is still present in this commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
