guluo2016 commented on code in PR #7719:
URL: https://github.com/apache/hbase/pull/7719#discussion_r2788912049
##########
hbase-asyncfs/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputHelper.java:
##########
@@ -345,7 +345,8 @@ protected void channelRead0(ChannelHandlerContext ctx,
BlockOpResponseProto resp
if (PipelineAck.isRestartOOBStatus(pipelineStatus)) {
throw new IOException("datanode " + dnInfo + " is restarting");
}
- String logInfo = "ack with firstBadLink as " +
resp.getFirstBadLink();
+ String logInfo =
+ "ack with firstBadLink as " + resp.getFirstBadLink() + " from
datanode " + dnInfo;
Review Comment:
Overall looks good. Just some minor nits.
In a previous change, we print both the hostname and IP when printing
datanode info, details see: https://github.com/apache/hbase/pull/6148
It might be better to follow that same pattern here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
