jinhyukify commented on code in PR #7740: URL: https://github.com/apache/hbase/pull/7740#discussion_r2796378497
########## hbase-common/src/main/java/org/apache/hadoop/hbase/util/XXH3.java: ########## @@ -0,0 +1,557 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.util; + +import static java.lang.Integer.toUnsignedLong; + +import org.apache.yetus.audience.InterfaceAudience; +import org.apache.yetus.audience.InterfaceStability; + +/** + * XXH3 64-bit hash implementation. + * <p> + * Optimized for modern CPU architectures, providing high throughput, strong dispersion, and minimal + * memory usage. Designed for low-latency, zero-allocation hashing in most cases. + * <p> + * Note, however, that when the input exceeds 240 bytes and a non-default seed (anything other than + * {@code 0}) is used, a derived secret must be generated internally, which results in a temporary + * byte-array allocation. + * @see <a href= + * "https://github.com/Cyan4973/xxHash/blob/dev/doc/xxhash_spec.md#xxh3-algorithm-overview";>XXH3 + * Algorithm</a> + */ [email protected] [email protected] +public class XXH3 extends Hash implements Hash64 { Review Comment: I mostly followed the algorithm as described here [xxh3-algorithm-overview](https://github.com/Cyan4973/xxHash/blob/dev/doc/xxhash_spec.md#xxh3-algorithm-overview) Also referenced the original implementation. https://xxhash.com/doc/v0.8.2/xxhash_8h_source.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
