Apache9 commented on code in PR #7749:
URL: https://github.com/apache/hbase/pull/7749#discussion_r2804796906
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/RawScanQueryMatcher.java:
##########
@@ -40,7 +40,9 @@ public MatchCode match(ExtendedCell cell) throws IOException {
return MatchCode.DONE_SCAN;
}
MatchCode returnCode = preCheck(cell);
- if (returnCode != null) {
+ // "Skip" indicates that the cell was expired due to cell TTL.
+ // We need to include it in the raw scan.
+ if (returnCode != null && returnCode != MatchCode.SKIP) {
Review Comment:
I prefer we add a flag in preCheck to tell the method that whether this is a
raw scan? I'm afarid in the future we may add other checks in the preCheck
method and break raw scan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
