DieterDP-ng commented on code in PR #7761:
URL: https://github.com/apache/hbase/pull/7761#discussion_r2816319265
##########
hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/master/TestBackupLogCleaner.java:
##########
@@ -215,6 +216,59 @@ public void testBackupLogCleaner() throws Exception {
}
}
+ @Test
+ public void testRemovedTableDoesNotPinWals() throws Exception {
Review Comment:
The name of this test is misleading. I'd also add a textual description as
to the specific case you're checking here.
The current name implies it has to do with a table that was removed. That is
also the problem originally encountered (in NGDATA): logs were not being
removed for a table that has already been removed. But you're not testing for
that here, this test doesn't remove a table.
There's a difference in the logic that's relevant. If you were to extend
your testcase to the following: `full backup F1`, `incremental I1`, `full
backup F2` (table 1 only), `incremental I2` (table 1 only), `delete F1, I1`,
I'm pretty sure the test would fail because `I2` would still refer to table2.
However, if you deleted table 2 after `I1`, I suspect it will work as
expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
