hgromer commented on code in PR #7582:
URL: https://github.com/apache/hbase/pull/7582#discussion_r2817341872
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/IncrementalBackupManager.java:
##########
@@ -228,15 +263,6 @@ private List<String> getLogFilesForNewBackup(Map<String,
Long> olderTimestamps,
} else if (currentLogTS > oldTimeStamp) {
resultLogFiles.add(currentLogFile);
}
-
- // It is possible that a host in .oldlogs is an obsolete region server
Review Comment:
> In a hypothetical case like that, it could be possible that there's a
significant difference in the everything-up-to-this-point-is-backed-up between
different tables. If the user does some kind of cross-table operation, there's
a higher change of data being out of sync.
Hmm do you mind elaborating on this a bit, I'm not sure I quite understand.
If the boundaries are based on the the log files that were included in the
backup, I'm not sure how things might be out of sync in a way that causes
issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
