liuxiaocs7 commented on code in PR #7726:
URL: https://github.com/apache/hbase/pull/7726#discussion_r2875886727
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HeapMemoryManager.java:
##########
@@ -137,16 +139,20 @@ private boolean doInit(Configuration conf) {
globalMemStorePercentMaxRange =
conf.getFloat(MEMSTORE_SIZE_MAX_RANGE_KEY, globalMemStorePercent);
if (globalMemStorePercent < globalMemStorePercentMinRange) {
- LOG.warn("Setting " + MEMSTORE_SIZE_MIN_RANGE_KEY + " to " +
globalMemStorePercent
- + ", same value as " + MemorySizeUtil.MEMSTORE_SIZE_KEY
- + " because supplied value greater than initial memstore size value.");
+ LOG.warn(
+ "Setting {} to {} (lookup order: {} -> {}), same value as "
Review Comment:
Seems we have 4 `{}` and 4 params here, and it is enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
