anmolnar commented on code in PR #7891:
URL: https://github.com/apache/hbase/pull/7891#discussion_r2920159794
##########
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/WALPlayer.java:
##########
@@ -378,14 +380,32 @@ public Job createSubmittableJob(String[] args) throws
IOException {
Path outputDir = new Path(hfileOutPath);
FileOutputFormat.setOutputPath(job, outputDir);
job.setMapOutputValueClass(MapReduceExtendedCell.class);
- try (Connection conn = ConnectionFactory.createConnection(conf);) {
- List<TableInfo> tableInfoList = new ArrayList<TableInfo>();
- for (TableName tableName : tableNames) {
+ try (Connection conn = ConnectionFactory.createConnection(conf)) {
+ if (conf.getBoolean(MULTI_TABLE_HFILEOUTPUTFORMAT_CONF_KEY, true)) {
Review Comment:
I think we should add a constant to the default value as well next to the
conf key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
