[
https://issues.apache.org/jira/browse/HBASE-6702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446122#comment-13446122
]
Jesse Yates commented on HBASE-6702:
------------------------------------
One of the most annoying parts about writing tests has been making sure to
include the ResourceChecker in all the tests. Its a one liner but needs to be
done _everywhere_. I'd propose that as part of this ticket we also go back to a
HBaseTest superclass for tests that includes this one-liner so we don't have
duplicate code that is common all over the place (one of the best gains from
OOP).
WRT what to do with the ResourceChecker itself, I'd like to see a split of its
responsibilities into two classes. (1) A general resource checker that checks
on things like threads, thread pools, files, etc., and (2) an
HBaseResourceChecker that extends the above and also checks HBase specific
things like HConnections, etc.
(1) would then be moved into hbase-common and used for those tests, while (2)
would continue as the resource checker for any of the hbase-server (or its
dependencies) tests.
> ResourceChecker refinement
> --------------------------
>
> Key: HBASE-6702
> URL: https://issues.apache.org/jira/browse/HBASE-6702
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Fix For: 0.96.0
>
>
> The ResourceChecker was added by N. Keywal to help resolve some hadoop qa
> issues, but has since not be widely utilized. Further, with modularization we
> have had to drop the ResourceChecker from the tests that are moved into the
> hbase-common module because bringing the ResourceChecker up to hbase-common
> would involved bringing all its dependencies (which are quite far reaching).
> The quest then is, what should we do with it? Get rid of it? Refactor and
> resuse?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
