[
https://issues.apache.org/jira/browse/HBASE-6234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446172#comment-13446172
]
Matt Corgan commented on HBASE-6234:
------------------------------------
btw - i am all for having that kind of test monitoring code thoroughly used in
all the tests. I justified dropping it in this case because it was the only
thing standing in the way of an otherwise clean module refactoring... i think
it's much safer to keep the refactorings coming steadily in small patches than
to try to yank apart the whole code base at once. Seemed like a good place to
snip some dependencies without major collateral damage. We should already be
thinking of how to clean up the damage (as Jesse already is in HBASE-6702).
Along the lines of what stack says above, the tests in hbase-common should
generally (maybe without exception?) not use external resources like the
minicluster or the filesystem. If we find ourselves wanting to put minicluster
tests in hbase-common, i would encourage us to further split the hbase-common
module so that we retain some central module that holds the crown-jewels of
hbase (KeyValue, Bytes, comparators, etc).
> Move simple KeyValue tests to hbase-common module
> -------------------------------------------------
>
> Key: HBASE-6234
> URL: https://issues.apache.org/jira/browse/HBASE-6234
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Matt Corgan
> Assignee: Matt Corgan
> Fix For: 0.96.0
>
> Attachments: HBASE-6234-v1.patch, HBASE-6234-v2.patch
>
>
> TestKeyValue, LoadTestKVGenerator, and TestLoadTestKVGenerator should move up
> to hbase-common. This brings MD5Hash up as a dependency as well.
> To play well with Maven as discussed in HBASE-6162, I moved
> LoadTestKVGenerator from the src/test folder to src/main folder so that tests
> in other modules can see it. A couple other files' import statements were
> affected by this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
