arvindKandpal-ksolves commented on PR #8014: URL: https://github.com/apache/hbase/pull/8014#issuecomment-4169397590
I've raised the backport for branch-2.5 based on the feedback: - Cherry-picked the commit from master and amended the message. - Handled a minor merge conflict in hirb.rb gracefully to ensure it stays fully compatible with the older JRuby version used in branch-2.5, while keeping the core bugfix exactly the same. - Ran manual tests on a local standalone cluster. When testing the bad syntax (list_namespace, 'ns.*') and variable assignments (list = 10), the shell correctly printed the expected WARN messages and caught the standard JRuby SyntaxError. - Note on Sanity testing: When running subsequent commands (like create_namespace), my local Zookeeper timed out due to local environment constraints. However, the shell remained completely alive and active, successfully attempting to execute the commands. This proves the Ruby binding did not get corrupted and the fix works perfectly on this branch. - Automated shell tests (mvn test -Dtest=TestShell -pl hbase-shell -Dhadoop.profile=3.0) also passed locally with BUILD SUCCESS. This looks ready from my side. I will start working on the branch-2.6 backport next. cc @NihalJain @Apache9 @liuxiaocs7 @vaijosh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
