[
https://issues.apache.org/jira/browse/HBASE-6516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13447743#comment-13447743
]
Jonathan Hsieh edited comment on HBASE-6516 at 9/5/12 2:14 AM:
---------------------------------------------------------------
Looks pretty good. I'm going to fix some nits and spacing issues on and let
the hadoopqa bot give a try.
One major thing was that this change was missing (in v3 but not v4) which
prevented compilation: (I've going to fix for the next version.).
{code}
@@ -258,7 +270,7 @@
* @return The 'current' tableinfo file.
* @throws IOException
*/
- private static FileStatus getTableInfoPath(final FileSystem fs,
+ public static FileStatus getTableInfoPath(final FileSystem fs,
final Path tabledir)
throws IOException {
FileStatus [] status = FSUtils.listStatus(fs, tabledir, new PathFilter() {
{code}
Fixed a few minor nits like this spelling error.
{code}
+ @Test
+ public void testHbckMissingTableinfo() throws Exception {
+ String table = "tabeInfo";
+ FileSystem fs = null;
+ Path tableinfo = null;
+
{code}
was (Author: jmhsieh):
Looks pretty good. I'm going to fix some nits and spacing issues on and
let the hadoopqa bot give a try.
One major thing was that this change was missing (in v3 but not v4) which
prevented compilation: (I've going to fix for the next version.).
{code}
@@ -258,7 +270,7 @@
* @return The 'current' tableinfo file.
* @throws IOException
*/
- private static FileStatus getTableInfoPath(final FileSystem fs,
+ public static FileStatus getTableInfoPath(final FileSystem fs,
final Path tabledir)
throws IOException {
FileStatus [] status = FSUtils.listStatus(fs, tabledir, new PathFilter() {
{code}
{code}
+ @Test
+ public void testHbckMissingTableinfo() throws Exception {
+ String table = "tabeInfo";
+ FileSystem fs = null;
+ Path tableinfo = null;
+
{code}
> hbck cannot detect any IOException while ".tableinfo" file is missing
> ---------------------------------------------------------------------
>
> Key: HBASE-6516
> URL: https://issues.apache.org/jira/browse/HBASE-6516
> Project: HBase
> Issue Type: Bug
> Components: hbck
> Affects Versions: 0.94.0, 0.96.0
> Reporter: Jie Huang
> Assignee: Jie Huang
> Attachments: hbase-6516.patch, hbase-6516-v2.patch,
> hbase-6516-v3.patch, hbase-6516-v4.patch, hbase-6516-v5.patch
>
>
> HBaseFsck checks those missing .tableinfo files in loadHdfsRegionInfos()
> function. However, no IoException will be catched while .tableinfo is
> missing, since "FSTableDescriptors.getTableDescriptor" doesn't throw any
> IoException.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
