Copilot commented on code in PR #8152:
URL: https://github.com/apache/hbase/pull/8152#discussion_r3148821198
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/tool/CanaryTool.java:
##########
@@ -798,7 +798,7 @@ public Void call() {
private static final long DEFAULT_TIMEOUT = 600000; // 10 mins
private static final int MAX_THREADS_NUM = 16; // #threads to contact regions
- private static final Logger LOG = LoggerFactory.getLogger(Canary.class);
+ private static final Logger LOG = LoggerFactory.getLogger(CanaryTool.class);
Review Comment:
This changes the SLF4J logger category from `Canary` to `CanaryTool`, which
can break existing operator log configuration (e.g., log4j properties targeting
the old category) and result in missing expected logs. If logger category
stability is important for this tool, consider preserving the previous category
(e.g., via a string logger name) or documenting the category change in release
notes/migration guidance.
```suggestion
private static final Logger LOG = LoggerFactory.getLogger("Canary");
```
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java:
##########
@@ -379,7 +379,7 @@ class RawAsyncHBaseAdmin implements AsyncAdmin {
public static final String FLUSH_TABLE_PROCEDURE_SIGNATURE =
"flush-table-proc";
- private static final Logger LOG =
LoggerFactory.getLogger(AsyncHBaseAdmin.class);
+ private static final Logger LOG =
LoggerFactory.getLogger(RawAsyncHBaseAdmin.class);
Review Comment:
This updates the logger category from `AsyncHBaseAdmin` to
`RawAsyncHBaseAdmin`. If downstream deployments filter/route client logs by the
previous category, this can change logging behavior unexpectedly. If the intent
is purely to fix mismatched references while preserving loggers consumed
externally, consider keeping the previous category (e.g., using the old class
or a constant string name) or calling out this compatibility impact explicitly.
```suggestion
private static final Logger LOG =
LoggerFactory.getLogger(AsyncHBaseAdmin.class);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
