[
https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448142#comment-13448142
]
Ted Yu commented on HBASE-6669:
-------------------------------
To generate patch, from the root of your workspace, type:
{code}
svn diff
hbase-server/src/main/java/org/apache/hadoop/hbase/client/coprocessor/BigDecimalColumnInterpreter.java
{code}
Year is not needed for license:
{code}
+ * Copyright 2011 The Apache Software Foundation
{code}
Remove the following comment:
{code}
+ // TODO Auto-generated method stub
{code}
Either move the return statement to the end of if statement or enclose it in
curly braces:
{code}
+ if (val1 == null)
+ return null;
{code}
The rest looks fine.
TestAggregateProtocol tests LongColumnInterpreter. You should create a new test
file to test your class.
Thanks
> Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
> ------------------------------------------------------------------------------
>
> Key: HBASE-6669
> URL: https://issues.apache.org/jira/browse/HBASE-6669
> Project: HBase
> Issue Type: New Feature
> Components: client, coprocessors
> Reporter: Anil Gupta
> Priority: Minor
> Labels: client, coprocessors
> Attachments: BigDecimalColumnInterpreter.java,
> BigDecimalColumnInterpreter.patch, BigDecimalColumnInterpreter.patch
>
>
> I recently created a Class for doing aggregations(sum,min,max,std) on values
> stored as BigDecimal in HBase. I would like to commit the
> BigDecimalColumnInterpreter into HBase. In my opinion this class can be used
> by a wide variety of users. Please let me know if its not appropriate to add
> this class in HBase.
> Thanks,
> Anil Gupta
> Software Engineer II, Intuit, Inc
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
