liuxiaocs7 commented on code in PR #8185:
URL: https://github.com/apache/hbase/pull/8185#discussion_r3210577285
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactSplitThread.java:
##########
@@ -123,7 +117,7 @@ public void testThreadPoolSizeTuning() throws Exception {
try {
regionServer.getCompactSplitThread().onConfigurationChange(conf);
} catch (IllegalArgumentException iae) {
- Assert.fail("Update bigger configuration failed!");
+ fail("Update bigger configuration failed!");
Review Comment:
Agreed. I changed this to `assertDoesNotThrow `so we keep the original
exception as the cause if the update fails, instead of swallowing it with
`fail(message)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
