sanjeet006py commented on code in PR #8236:
URL: https://github.com/apache/hbase/pull/8236#discussion_r3241379574
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotRegionLocator.java:
##########
@@ -119,6 +119,12 @@ public List<HRegionLocation> getAllRegionLocations()
throws IOException {
return rawLocations;
}
+ @Override
+ public List<HRegionLocation> getRegionLocations(byte[] startKey, int limit)
throws IOException {
+ // No need to page as region locations are already in-memory.
+ return getAllRegionLocations();
+ }
Review Comment:
Yeah, I was also wondering same. Thanks for bringing this up. Instead of
implementing paging here, shall I throw an exception saying use
getAllRegionLocations as I don't see advantage of paging in here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
